search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Updating Activator's `terminationGracePeriodSeconds` value #1295

Open psschwei opened 1 year ago

psschwei commented 1 year ago

Hello everyone.

I am also interested in setting max-revision-timeout-seconds to a larger value. However I can't find how to update the terminationGracePeriod in activator.

From @mkyrilov 's comment in Serving:

I am using the operator to install Knative Serving:

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  version: 1.8.0 # Same version as the operator
  config:
    defaults:
      max-revision-timeout-seconds: "7200" # 120 minutes
    domain:
      kn.example.com: "" # your DNS
    features:
      kubernetes.podspec-persistent-volume-claim: "enabled"
      kubernetes.podspec-persistent-volume-write: "enabled"
      kubernetes.podspec-affinity: "enabled"
      kubernetes.podspec-tolerations: "enabled"
      kubernetes.podspec-init-containers: "enabled"
    istio:
      gateway.knative-serving.knative-ingress-gateway: istio-ingressgateway.istio-ingress.svc.cluster.local

Does anyone know how to achieve this?

I did try editing the activator deployment manually. It updates fine, but then immediately gets reverted back. I am assuming the operator does this.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 1 year ago

/remove-lifecycle stale

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 1 year ago

/remove-lifecycle stale

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 10 months ago

/remove-lifecycle stale

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 7 months ago

/remove-lifecycle stale

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 4 months ago

/remove-lifecycle stale

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mkyrilov commented 1 month ago

/remove-lifecycle stale

CarlosDomingues commented 2 weeks ago

@psschwei did you find a solution?

I tried increasing max-revision-timeout-seconds, but when trying long requests I'm getting this error: activator request timeout

I believe I could soulve that by increasing the Activator's terminationGracePeriodSeconds value

psschwei commented 2 weeks ago

@CarlosDomingues this wasn't my issue, I was just moving @mkyrilov 's comments into this repo

cc @houshengbo