knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 98 forks source link

Add more env vars for pingsource adapter env var preservation #1534

Closed aliok closed 1 year ago

aliok commented 1 year ago

Fixes #

Proposed Changes

Release Note

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (72e396b) 79.10% compared to head (0542aa6) 79.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1534 +/- ## ======================================= Coverage 79.10% 79.10% ======================================= Files 40 40 Lines 1809 1809 ======================================= Hits 1431 1431 Misses 275 275 Partials 103 103 ``` | [Files Changed](https://app.codecov.io/gh/knative/operator/pull/1534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [...knativeeventing/common/replicasenvvarstransform.go](https://app.codecov.io/gh/knative/operator/pull/1534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIva25hdGl2ZWV2ZW50aW5nL2NvbW1vbi9yZXBsaWNhc2VudnZhcnN0cmFuc2Zvcm0uZ28=) | `70.58% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [aliok,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matzew commented 1 year ago

@aliok we might need backports?

aliok commented 1 year ago

@aliok we might need backports?

Yes, definitely. I am figuring out right now which branches to backport this.

We (RHAT) need it in 0.36.5, which is 1.9.5.

So, all the way to 1.9: 1.11, 1.10, 1.9

aliok commented 1 year ago

/cherrypick release-1.11

knative-prow-robot commented 1 year ago

@aliok: new pull request created: #1535

In response to [this](https://github.com/knative/operator/pull/1534#issuecomment-1681918559): >/cherrypick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 1 year ago

/cherrypick release-1.10

aliok commented 1 year ago

/cherrypick release-1.9

knative-prow-robot commented 1 year ago

@aliok: new pull request created: #1537

In response to [this](https://github.com/knative/operator/pull/1534#issuecomment-1682049678): >/cherrypick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 1 year ago

@aliok: new pull request created: #1538

In response to [this](https://github.com/knative/operator/pull/1534#issuecomment-1682049925): >/cherrypick release-1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.