search

knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 98 forks source link

[release-1.11] Add more env vars for pingsource adapter env var preservation #1535

Closed knative-prow-robot closed 1 year ago

knative-prow-robot commented 1 year ago

This is an automated cherry-pick of #1534

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.
aliok commented 1 year ago

/cherrypick release-1.10

knative-prow-robot commented 1 year ago

@aliok: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1535#issuecomment-1681920190): >/cherrypick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.11/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ef32df) 79.22% compared to head (1e98c84) 79.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.11 #1535 +/- ## ============================================= Coverage 79.22% 79.22% ============================================= Files 40 40 Lines 1800 1800 ============================================= Hits 1426 1426 Misses 272 272 Partials 102 102 ``` | [Files Changed](https://app.codecov.io/gh/knative/operator/pull/1535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [...knativeeventing/common/replicasenvvarstransform.go](https://app.codecov.io/gh/knative/operator/pull/1535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIva25hdGl2ZWV2ZW50aW5nL2NvbW1vbi9yZXBsaWNhc2VudnZhcnN0cmFuc2Zvcm0uZ28=) | `70.58% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aliok commented 1 year ago

/close This fails. Created https://github.com/knative/operator/pull/1536

knative-prow[bot] commented 1 year ago

@aliok: Closed this PR.

In response to [this](https://github.com/knative/operator/pull/1535#issuecomment-1682047867): >/close >This fails. Created https://github.com/knative/operator/pull/1536 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.