search

knative / operator

Combined operator for Knative.
Apache License 2.0
189 stars 100 forks source link

Fixed the image overriding issue for Jobs #1554

Closed houshengbo closed 1 year ago

houshengbo commented 1 year ago

Fixes: #1553

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95b0179) 79.25% compared to head (766c825) 79.25%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1554 +/- ## ======================================= Coverage 79.25% 79.25% ======================================= Files 40 40 Lines 1822 1822 ======================================= Hits 1444 1444 Misses 275 275 Partials 103 103 ``` | [Files Changed](https://app.codecov.io/gh/knative/operator/pull/1554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/images.go](https://app.codecov.io/gh/knative/operator/pull/1554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2ltYWdlcy5nbw==) | `78.40% <100.00%> (ø)` | | | [pkg/reconciler/common/transformers.go](https://app.codecov.io/gh/knative/operator/pull/1554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3RyYW5zZm9ybWVycy5nbw==) | `82.60% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [dprotaso,houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
houshengbo commented 1 year ago

/cherry-pick release-1.11

knative-prow-robot commented 1 year ago

@houshengbo: new pull request created: #1555

In response to [this](https://github.com/knative/operator/pull/1554#issuecomment-1710668598): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.