knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 98 forks source link

[release-1.11] Fixed the image overriding issue for Jobs #1555

Closed knative-prow-robot closed 1 year ago

knative-prow-robot commented 1 year ago

This is an automated cherry-pick of #1554

houshengbo commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.11/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d481e87) 79.22% compared to head (48f1953) 79.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.11 #1555 +/- ## ============================================= Coverage 79.22% 79.22% ============================================= Files 40 40 Lines 1800 1800 ============================================= Hits 1426 1426 Misses 272 272 Partials 102 102 ``` | [Files Changed](https://app.codecov.io/gh/knative/operator/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/images.go](https://app.codecov.io/gh/knative/operator/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2ltYWdlcy5nbw==) | `78.40% <100.00%> (ø)` | | | [pkg/reconciler/common/transformers.go](https://app.codecov.io/gh/knative/operator/pull/1555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3RyYW5zZm9ybWVycy5nbw==) | `82.60% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.