search

knative / operator

Combined operator for Knative.
Apache License 2.0
185 stars 98 forks source link

[release-1.11] set HPA replica values when workload overrides are set #1575

Closed knative-prow-robot closed 11 months ago

knative-prow-robot commented 11 months ago

This is an automated cherry-pick of #1548

The operator now sets HorizontalPodAutoscaler replicas (on resources with HPAs) when workload overrides are defined.
knative-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/operator/blob/release-1.11/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ReToCode commented 11 months ago

Does not work because of generated files, so doing it manually:

https://github.com/knative/operator/pull/1576 and https://github.com/knative/operator/pull/1577

ReToCode commented 11 months ago

/close

knative-prow[bot] commented 11 months ago

@ReToCode: Closed this PR.

In response to [this](https://github.com/knative/operator/pull/1575#issuecomment-1742863933): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.