search

knative / operator

Combined operator for Knative.
Apache License 2.0
185 stars 98 forks source link

[release-1.10] manual back-port of https://github.com/knative/operator/pull/1548 #1577

Closed ReToCode closed 11 months ago

ReToCode commented 11 months ago

Proposed Changes

Release Note

The operator now sets HorizontalPodAutoscaler replicas (on resources with HPAs) when workload overrides are defined.
ReToCode commented 11 months ago

/assign @pierDipi /assign @skonto /assign @nak3

codecov[bot] commented 11 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (acf0695) 79.32% compared to head (3ff4678) 79.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.10 #1577 +/- ## ================================================ - Coverage 79.32% 79.26% -0.06% ================================================ Files 40 41 +1 Lines 1775 1804 +29 ================================================ + Hits 1408 1430 +22 - Misses 267 272 +5 - Partials 100 102 +2 ``` | [Files](https://app.codecov.io/gh/knative/operator/pull/1577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/transformers.go](https://app.codecov.io/gh/knative/operator/pull/1577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3RyYW5zZm9ybWVycy5nbw==) | `85.18% <100.00%> (-0.53%)` | :arrow_down: | | [pkg/reconciler/common/ha.go](https://app.codecov.io/gh/knative/operator/pull/1577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2hhLmdv) | `77.77% <80.00%> (+13.77%)` | :arrow_up: | | [pkg/reconciler/common/workload\_override.go](https://app.codecov.io/gh/knative/operator/pull/1577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3dvcmtsb2FkX292ZXJyaWRlLmdv) | `85.90% <72.72%> (-1.24%)` | :arrow_down: | | [pkg/reconciler/common/hpa.go](https://app.codecov.io/gh/knative/operator/pull/1577?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2hwYS5nbw==) | `65.90% <65.90%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/knative/operator/pull/1577/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ReToCode commented 11 months ago

/test integration-tests

nak3 commented 11 months ago

/lgtm /approve

ReToCode commented 11 months ago

/assign @houshengbo

knative-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.10/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment