knative / operator

Combined operator for Knative.
Apache License 2.0
189 stars 100 forks source link

Fix wrongly dropped transformer #1580

Closed ReToCode closed 1 year ago

ReToCode commented 1 year ago

Changes

https://github.com/knative/operator/pull/1577 accidentally dropped the JobTransformer. This adds it back.

/assign @pierDipi

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (d2e3906) 79.26% compared to head (e9ffee4) 79.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.10 #1580 +/- ## ================================================ + Coverage 79.26% 79.33% +0.06% ================================================ Files 41 41 Lines 1804 1805 +1 ================================================ + Hits 1430 1432 +2 + Misses 272 271 -1 Partials 102 102 ``` | [Files](https://app.codecov.io/gh/knative/operator/pull/1580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/transformers.go](https://app.codecov.io/gh/knative/operator/pull/1580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3RyYW5zZm9ybWVycy5nbw==) | `85.71% <100.00%> (+0.52%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/knative/operator/pull/1580/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.10/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment