knative / operator

Combined operator for Knative.
Apache License 2.0
185 stars 98 forks source link

Support Eventing TLS #1582

Closed pierDipi closed 11 months ago

pierDipi commented 11 months ago

Fixes #1583

Proposed Changes

I've tested this locally following this flow:

  1. Apply a KnativeEventing instance
    apiVersion: operator.knative.dev/v1beta1
    kind: KnativeEventing
    metadata:
    name: knative-eventing
    namespace: knative-eventing
    spec: {}
  2. wait for it to become ready
  3. Install cert manager kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.13.1/cert-manager.yaml
  4. Enable the feature
    apiVersion: operator.knative.dev/v1beta1
    kind: KnativeEventing
    metadata:
    name: knative-eventing
    namespace: knative-eventing
    spec:
    config:
    features:
      transport-encryption: strict
  5. Create a broker after creating a namespace kubectl create namespace ai-demo
    apiVersion: eventing.knative.dev/v1
    kind: Broker
    metadata:
    name: analytics-broker
    namespace: ai-demo
  6. View Broker ready with https address
    $ k get brokers.eventing.knative.dev -A
    NAMESPACE   NAME               URL                                                                                  AGE     READY   REASON
    ai-demo     analytics-broker   https://broker-ingress.knative-eventing.svc.cluster.local/ai-demo/analytics-broker   4m26s   True    

Release Note

Support Eventing transport-encryption (TLS), for more information, see https://knative.dev/docs/eventing/experimental-features/transport-encryption/
knative-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 11 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (bcfd8c0) 79.19% compared to head (b4b6942) 79.40%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1582 +/- ## ========================================== + Coverage 79.19% 79.40% +0.21% ========================================== Files 41 41 Lines 1855 1845 -10 ========================================== - Hits 1469 1465 -4 + Misses 281 277 -4 + Partials 105 103 -2 ``` | [Files](https://app.codecov.io/gh/knative/operator/pull/1582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [.../reconciler/common/poddisruptionbudget\_override.go](https://app.codecov.io/gh/knative/operator/pull/1582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL3BvZGRpc3J1cHRpb25idWRnZXRfb3ZlcnJpZGUuZ28=) | `71.42% <28.57%> (+10.13%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pierDipi commented 11 months ago

/unhold