search

knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

Add knativeeventing extra again #1587

Closed pierDipi closed 10 months ago

pierDipi commented 10 months ago

It was inadvertently removed in [1].

[1] https://github.com/knative/operator/commit/6e5a006d81c66293ecf97bace806276020f1ca11

pierDipi commented 10 months ago

/cherry-pick release-1.11

knative-prow-robot commented 10 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1587#issuecomment-1753063859): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (63838ab) 79.40% compared to head (7a6178f) 79.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1587 +/- ## ======================================= Coverage 79.40% 79.40% ======================================= Files 41 41 Lines 1845 1845 ======================================= Hits 1465 1465 Misses 277 277 Partials 103 103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 10 months ago

/lgtm /approve

knative-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 10 months ago

@pierDipi: new pull request created: #1588

In response to [this](https://github.com/knative/operator/pull/1587#issuecomment-1753063859): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.