search

knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

Improve manifest deletion error handling #1589

Closed pierDipi closed 10 months ago

pierDipi commented 10 months ago

It might happen that not all resources were created successfully so we should not fail finalization when resources are not found, we can just ignore not found errors.

pierDipi commented 10 months ago

/cc @skonto @houshengbo @matzew @creydr

pierDipi commented 10 months ago

/cherry-pick release-1.11

knative-prow-robot commented 10 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1589#issuecomment-1753155912): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pierDipi commented 10 months ago

/cherry-pick release-1.10

knative-prow-robot commented 10 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1589#issuecomment-1753156115): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8412d98) 79.40% compared to head (a9e0019) 79.40%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1589 +/- ## ======================================= Coverage 79.40% 79.40% ======================================= Files 41 41 Lines 1845 1845 ======================================= Hits 1465 1465 Misses 277 277 Partials 103 103 ``` | [Files](https://app.codecov.io/gh/knative/operator/pull/1589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/install.go](https://app.codecov.io/gh/knative/operator/pull/1589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2luc3RhbGwuZ28=) | `41.02% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [creydr,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pierDipi commented 10 months ago

Cherry pick done manually in https://github.com/knative/operator/pull/1591

pierDipi commented 10 months ago

/retest-required

houshengbo commented 10 months ago

/test eventing-upgrade-tests /lgtm

knative-prow-robot commented 10 months ago

@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to [this](https://github.com/knative/operator/pull/1589#issuecomment-1753155912): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 10 months ago

@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to [this](https://github.com/knative/operator/pull/1589#issuecomment-1753156115): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.