Closed pierDipi closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
8412d98
) 79.40% compared to head (6fd2b9c
) 79.40%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cherry-pick release-1.11
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: creydr, pierDipi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client
/cherry-pick release-1.11
@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client
Done manually https://github.com/knative/operator/pull/1591, bot is broken https://github.com/kubernetes/test-infra/issues/30937
For optional resources like cert-manager's Certificates and Issuers, we don't want to fail finalization when such operators are not installed, so during finalization, we split the resources in
Then, we delete
resources
first and after we delete optional resources while also ignoring errors returned when such operators are not instaled.