search

knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

[release-1.11] Improve KnativeEventing finalization for TLS resources (#1590) #1591

Closed pierDipi closed 10 months ago

pierDipi commented 10 months ago

CP of https://github.com/knative/operator/pull/1590 and https://github.com/knative/operator/pull/1589

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4525683) 0.00% compared to head (b8e3f4b) 79.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.11 #1591 +/- ## ================================================= + Coverage 0 79.23% +79.23% ================================================= Files 0 41 +41 Lines 0 1830 +1830 ================================================= + Hits 0 1450 +1450 - Misses 0 276 +276 - Partials 0 104 +104 ``` | [Files](https://app.codecov.io/gh/knative/operator/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/reconciler/common/install.go](https://app.codecov.io/gh/knative/operator/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3JlY29uY2lsZXIvY29tbW9uL2luc3RhbGwuZ28=) | `41.02% <0.00%> (ø)` | | ... and [40 files with indirect coverage changes](https://app.codecov.io/gh/knative/operator/pull/1591/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 10 months ago

/lgtm /approve

knative-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.11/OWNERS)~~ [houshengbo,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment