knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

Shell executor logs through testing.T in upgrade tests #1598

Closed mgencur closed 5 months ago

mgencur commented 9 months ago

Similar to https://github.com/knative/serving/pull/14495

Fixes #

Proposed Changes

Release Note

knative-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 9 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matzew commented 9 months ago

@mgencur can you rebase?

github-actions[bot] commented 6 months ago

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

houshengbo commented 6 months ago

Let me ping @mgencur one more time to see if he can rebase and fix the CI issues with this PR.