search

knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

KnativeEventing logging changes don't take effect #1602

Closed epalchan closed 5 months ago

epalchan commented 9 months ago

Describe the bug Setting any of the configmap entries defined here does not modify the configuration change of any component due to the default zap-logger-config defined here- https://github.com/knative/operator/blob/main/cmd/operator/kodata/knative-eventing/1.11.5/2-eventing-core.yaml#L585-L605

Expected behavior Setting any of the entries such as zap-logger-config.level or loglevel.webhookto warn would modify the log level of the webhook (or all components) to warn.

To Reproduce Set any of the entries that are defined in the default entry zap-logger-config without defining zap-logger-config itself on the KnativeEventing CRD manifest and check whether they are implemented in the component logs.

Knative release version Operator 1.11.8, Eventing 1.11.5

Additional context This has not been checked on KnativeServing yet and could impact Serving as well.

epalchan commented 9 months ago

I was able to resolve this, the example configuration is incorrect and the entry should be loglevel.eventing-webhook to work.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.