search

knative / operator

Combined operator for Knative.
Apache License 2.0
181 stars 98 forks source link

Update istio gateway from v1alpha3 to v1beta1 #1628

Closed houshengbo closed 8 months ago

houshengbo commented 8 months ago

Fixes #1469

Proposed Changes

Release Note

knative-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7f4be55) 79.40% compared to head (6d3ba94) 79.37%. Report is 9 commits behind head on main.

Files Patch % Lines
pkg/reconciler/knativeserving/ingress/istio.go 75.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1628 +/- ## ========================================== - Coverage 79.40% 79.37% -0.03% ========================================== Files 41 41 Lines 1845 1857 +12 ========================================== + Hits 1465 1474 +9 - Misses 277 279 +2 - Partials 103 104 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nak3 commented 8 months ago

/lgtm

I opened the follow-up issue - https://github.com/knative/operator/issues/1646

houshengbo commented 8 months ago

/test eventing-upgrade-tests

houshengbo commented 8 months ago

/test eventing-upgrade-tests

houshengbo commented 8 months ago

/cherry-pick release-1.12

knative-prow-robot commented 8 months ago

@houshengbo: new pull request created: #1647

In response to [this](https://github.com/knative/operator/pull/1628#issuecomment-1839203431): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 8 months ago

/cherry-pick release-1.11

houshengbo commented 8 months ago

/cherry-pick release-1.10

knative-prow-robot commented 8 months ago

@houshengbo: #1628 failed to apply on top of branch "release-1.11":

Applying: Update istio gateway from v1alpha3 to v1beta1
Using index info to reconstruct a base tree...
M   pkg/apis/operator/base/ingressconfiguration.go
M   pkg/reconciler/knativeserving/ingress/istio.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/knativeserving/ingress/istio.go
CONFLICT (content): Merge conflict in pkg/reconciler/knativeserving/ingress/istio.go
Auto-merging pkg/apis/operator/base/ingressconfiguration.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update istio gateway from v1alpha3 to v1beta1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative/operator/pull/1628#issuecomment-1842698655): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 8 months ago

@houshengbo: #1628 failed to apply on top of branch "release-1.10":

Applying: Update istio gateway from v1alpha3 to v1beta1
Using index info to reconstruct a base tree...
M   pkg/apis/operator/base/ingressconfiguration.go
M   pkg/reconciler/knativeserving/ingress/istio.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/knativeserving/ingress/istio.go
CONFLICT (content): Merge conflict in pkg/reconciler/knativeserving/ingress/istio.go
Auto-merging pkg/apis/operator/base/ingressconfiguration.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update istio gateway from v1alpha3 to v1beta1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative/operator/pull/1628#issuecomment-1842698943): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.