search

knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 100 forks source link

Add option to configure config-contour ConfigMap for custom Contour installation #1648

Closed tmyhu closed 6 months ago

tmyhu commented 10 months ago

Problem Currently, if I enable Contour in KnativeServing the operator will deploy net-contour with a ConfigMap config-contour that is hardcoded to point at contour-external/envoy and contour-internal/envoy (https://github.com/knative-extensions/net-contour/blob/release-1.12/config/config-contour.yaml#L50). So this only works if using the Contour deployment example yaml from the Knative docs but I cannot change this for a custom Contour installation in a different namespace as the operator would undo any modification to the configmap.
It would be very helpful if the contour namespace and envoy service names could be configured in KnativeServing custom resource under spec.ingress.contour

Persona: Which persona is this feature for? System Operator

Exit Criteria Deploy Knative Serving via the Operator and KnativeServing custom resource, deploy Contour under a different name/namespace than contour-external/envoy and have a working Ingress.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.