search

knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 100 forks source link

[release-1.11] Update istio gateway from v1alpha3 to v1beta1 (#1628) #1650

Closed houshengbo closed 10 months ago

houshengbo commented 10 months ago

cherry-pick of 5e2d097c768427a2f3c3d6fcaa8f1e36d7ca6b59

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b675338) 79.23% compared to head (c3749a9) 79.20%.

Files Patch % Lines
pkg/reconciler/knativeserving/ingress/istio.go 75.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.11 #1650 +/- ## ================================================ - Coverage 79.23% 79.20% -0.03% ================================================ Files 41 41 Lines 1830 1842 +12 ================================================ + Hits 1450 1459 +9 - Misses 276 278 +2 - Partials 104 105 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 10 months ago

/lgtm /approve

knative-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.11/OWNERS)~~ [dprotaso,houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment