search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Do not remove the resources if status.Manifests is empty #1661

Closed houshengbo closed 6 months ago

houshengbo commented 6 months ago

Fixes #1652

Proposed Changes

Release Note

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b12ea7d) 79.37% compared to head (b710333) 79.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1661 +/- ## ======================================= Coverage 79.37% 79.37% ======================================= Files 41 41 Lines 1857 1857 ======================================= Hits 1474 1474 Misses 279 279 Partials 104 104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 6 months ago

/test eventing-upgrade-tests

houshengbo commented 6 months ago

/test eventing-upgrade-tests

nak3 commented 6 months ago

/lgtm

houshengbo commented 6 months ago

/cherry-pick release-1.12

knative-prow-robot commented 6 months ago

@houshengbo: new pull request created: #1664

In response to [this](https://github.com/knative/operator/pull/1661#issuecomment-1882458451): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 6 months ago

/cherry-pick release-1.12

knative-prow-robot commented 6 months ago

@houshengbo: new pull request created: #1665

In response to [this](https://github.com/knative/operator/pull/1661#issuecomment-1882464749): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.