search

knative / operator

Combined operator for Knative.
Apache License 2.0
187 stars 100 forks source link

[release-1.12] Do not remove the resources if status.Manifests is empty #1664

Closed knative-prow-robot closed 9 months ago

knative-prow-robot commented 9 months ago

This is an automated cherry-pick of #1661

houshengbo commented 9 months ago

/lgtm /approve

knative-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/release-1.12/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bd823f9) 79.37% compared to head (c3547c5) 79.37%. Report is 1 commits behind head on release-1.12.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.12 #1664 +/- ## ============================================= Coverage 79.37% 79.37% ============================================= Files 41 41 Lines 1857 1857 ============================================= Hits 1474 1474 Misses 279 279 Partials 104 104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.