search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Allow configuration of Istio Gateway tls options #1700

Closed braunsonm closed 2 months ago

braunsonm commented 4 months ago

Describe the feature

Currently the docs recommend manually editing the Gateway object that is created by Knative (in the operators case) to add TLS options. This is risky as it can be overwritten by the operator. It would be must better if the operator supported specifying tls options such as credentialName and mode within the KnativeServing CR.

Docs which mention manually editing the Gateway object: https://knative.dev/docs/serving/encryption/using-certificates-in-networking-layer/#manually-adding-a-tls-certificate

braunsonm commented 4 months ago

Maybe this is also a bug but the documentation here: https://knative.dev/docs/install/operator/configuring-serving-cr/#servers-configuration-for-istio-gateways

Is wrong, you cannot configure the HTTPS protocol without the tls block. Your CR will never enter the ready status with the error configuration is invalid: server must have TLS settings for HTTPS/TLS protocols

braunsonm commented 2 months ago

Fixed in https://github.com/knative/operator/pull/1482