search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Added "trust.cert-manager.io" into the ClusterRole #1729

Closed houshengbo closed 3 months ago

houshengbo commented 3 months ago

Proposed Changes

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.92%. Comparing base (7fc93f6) to head (296aedc). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1729 +/- ## ========================================== + Coverage 63.60% 63.92% +0.32% ========================================== Files 53 53 Lines 2580 2606 +26 ========================================== + Hits 1641 1666 +25 + Misses 825 823 -2 - Partials 114 117 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 3 months ago

/test eventing-upgrade-tests

kuzm1ch commented 3 months ago

Could you check my clusterole rules:

  1. added access to clusterissuers in group cert-manager.io
  2. access to bundles in trust.cert-manager.io 
    - apiGroups:
  - "cert-manager.io"
resources:
  - certificates
  - issuers
  - clusterissuers
verbs:
  - create
  - delete
  - update
  - list
  - get
  - watch
- apiGroups:
  - "trust.cert-manager.io"
resources:
  - bundles
verbs:
  - create
  - delete
  - update
  - list
  - get
  - watch
houshengbo commented 3 months ago

/test integration-tests /test eventing-upgrade-tests

houshengbo commented 3 months ago

/cherry-pick release-1.13

knative-prow-robot commented 3 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1729#issuecomment-1989540663): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kuzm1ch commented 3 months ago

/lgtm

knative-prow[bot] commented 3 months ago

@kuzm1ch: changing LGTM is restricted to collaborators

In response to [this](https://github.com/knative/operator/pull/1729#issuecomment-1991479343): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 3 months ago

/test eventing-upgrade-tests

knative-prow-robot commented 3 months ago

@houshengbo: new pull request created: #1743

In response to [this](https://github.com/knative/operator/pull/1729#issuecomment-1989540663): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 3 months ago

/cherry-pick release-1.11

houshengbo commented 3 months ago

/cherry-pick release-1.12

knative-prow-robot commented 3 months ago

@houshengbo: new pull request created: #1747

In response to [this](https://github.com/knative/operator/pull/1729#issuecomment-1995899001): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 months ago

@houshengbo: new pull request created: #1748

In response to [this](https://github.com/knative/operator/pull/1729#issuecomment-1995899168): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.