search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Removed eventing-tls-networking.yaml from the manifests #1732

Closed houshengbo closed 3 months ago

houshengbo commented 3 months ago

Proposed Changes

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.60%. Comparing base (c85f8f3) to head (a535d0b). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1732 +/- ## ======================================= Coverage 63.60% 63.60% ======================================= Files 53 53 Lines 2580 2580 ======================================= Hits 1641 1641 Misses 825 825 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 3 months ago

/test eventing-upgrade-tests

houshengbo commented 3 months ago

/test eventing-upgrade-tests

pierDipi commented 3 months ago

/hold

why?

pierDipi commented 3 months ago

We're only reconciling those resources when the feature flag is enabled but if we remove the resources TLS won't be supported by the operator https://github.com/knative/operator/blob/918cb7ed99fe042e733a900a432edfc8585ac268/pkg/reconciler/knativeeventing/eventing_tls.go#L37

houshengbo commented 3 months ago

@pierDipi By default, the feature flag seems to be on, so the reconcile loop of operator runs into 

ClusterIssuer” in version “[cert-manager.io/v1](http://cert-manager.io/v1)`

However, if folks do not know cert-manager is the dependency, they would think it is a bug on operator. We do not have document from the operator's perspective how what to install and how to configure.

Per the discussion here: https://cloud-native.slack.com/archives/C04LMU33V1S/p1710250853335799, we need a better support of this TLS feature in later release. But for now, what is your suggestion to fix?

pierDipi commented 3 months ago

That's the problem, it's shouldn't be on by default