search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Ignore no match errors on deleting obsolete resources #1739

Closed pierDipi closed 3 months ago

pierDipi commented 3 months ago

Maybe Fixes #1737

with eventing TLS, there are optional resources, only applied when a feature flag is enabled, so we need to ignore No match kind errors.

pierDipi commented 3 months ago

/cherry-pick release-1.13

pierDipi commented 3 months ago

/cherry-pick release-1.12

knative-prow-robot commented 3 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672318): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672417): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pierDipi commented 3 months ago

/cherry-pick release-1.11

knative-prow-robot commented 3 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672492): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.54%. Comparing base (918cb7e) to head (1345fba).

Files Patch % Lines
pkg/reconciler/common/stages.go 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1739 +/- ## ========================================== - Coverage 63.60% 63.54% -0.06% ========================================== Files 53 53 Lines 2580 2584 +4 ========================================== + Hits 1641 1642 +1 - Misses 825 827 +2 - Partials 114 115 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pierDipi commented 3 months ago

/retest

houshengbo commented 3 months ago

/lgtm /approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 3 months ago

@pierDipi: new pull request created: #1740

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672318): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 months ago

@pierDipi: new pull request created: #1741

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672417): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 months ago

@pierDipi: new pull request created: #1742

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1994672492): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 3 months ago

/cherry-pick release-1.11

knative-prow-robot commented 3 months ago

@houshengbo: new pull request created: #1749

In response to [this](https://github.com/knative/operator/pull/1739#issuecomment-1995938448): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.