knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

add support for podDisruptionBudgets maxUnavailable #1764

Closed jdcmarques closed 2 months ago

jdcmarques commented 3 months ago

Fixes #1658

Proposed Changes

Release Note

Allow to use maxUnavailable on created PodDisruptionBudgets
linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 3 months ago

Welcome @jdcmarques! It looks like this is your first PR to knative/operator 🎉

knative-prow[bot] commented 3 months ago

Hi @jdcmarques. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.21%. Comparing base (f32bc7c) to head (1dc56cf). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1764 +/- ## ========================================== + Coverage 63.54% 66.21% +2.67% ========================================== Files 53 53 Lines 2584 2081 -503 ========================================== - Hits 1642 1378 -264 + Misses 827 588 -239 Partials 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 2 months ago

/ok-to-test

houshengbo commented 2 months ago

/lgtm

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, jdcmarques

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment