Closed kycheng closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kycheng Once this PR has been reviewed and has the lgtm label, please assign maximilien for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @kycheng! It looks like this is your first PR to knative/operator 🎉
Hi @kycheng. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
What is the reason for adding resource limit? Why is it just 100?
What is the reason for adding resource limit? Why is it just 100?
Sorry I forgot to add the reason.
I think increasing the resource limit is a better best practice to prevent pods from using resources infinitely (this is not currently happening.)
100 From the monitoring data of our operating environment, it seems that 100 is enough.
100 From the monitoring data of our operating environment, it seems that 100 is enough.
This might be true for your environment, but not for everyones. I'd argue that this is a concern each operator has to take care of and figure out the correct values for their installation.
I think increasing the resource limit is a better best practice to prevent pods from using resources infinitely (this is not currently happening.)
Based on the monitoring data of our environment, I set the request and limit values to 100m/100Mi
Proposed Changes
Release Note