search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Removed the namespace in Helm template #1805

Closed houshengbo closed 1 month ago

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
houshengbo commented 1 month ago

/cherry-pick release-1.14

knative-prow-robot commented 1 month ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative/operator/pull/1805#issuecomment-2123716374): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.21%. Comparing base (fadfe5e) to head (57a6e9a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1805 +/- ## ======================================= Coverage 66.21% 66.21% ======================================= Files 53 53 Lines 2081 2081 ======================================= Hits 1378 1378 Misses 588 588 Partials 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow-robot commented 1 month ago

@houshengbo: new pull request created: #1806

In response to [this](https://github.com/knative/operator/pull/1805#issuecomment-2123716374): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.