knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

Liveness probe cannot be removed #1817

Closed mbaynton closed 1 week ago

mbaynton commented 3 weeks ago

Describe the bug If LivenessProbes is set to an empty array, we expect it should remove the LivenessProbe from the associated deployment, but this dos not occur.

To Reproduce

...
 -  name: net-kourier-controller
    livenessProbes: []

Knative release version Operator 1.14.2

Additional context Copy/pasta error? https://github.com/knative/operator/blob/2614b77024599eb9aeec40bdf3405e4a8ae5744e/pkg/reconciler/common/workload_override.go#L226