search

knative / operator

Combined operator for Knative.
Apache License 2.0
179 stars 98 forks source link

fix liveness probe removal #1823

Closed mbaynton closed 1 week ago

mbaynton commented 2 weeks ago

/lint

Fixes #1817

Usage for this is e.g.

- name: 3scale-kourier-gateway
  livenessProbes:
  - container: kourier-gateway

Release Note

Fix bug preventing liveness probes to be overridden to no probe
knative-prow[bot] commented 2 weeks ago

Welcome @mbaynton! It looks like this is your first PR to knative/operator 🎉

knative-prow[bot] commented 2 weeks ago

Hi @mbaynton. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.36%. Comparing base (92e33ef) to head (88c70ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1823 +/- ## ========================================== + Coverage 66.21% 66.36% +0.14% ========================================== Files 53 53 Lines 2081 2081 ========================================== + Hits 1378 1381 +3 + Misses 588 586 -2 + Partials 115 114 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 1 week ago

/lgtm /approve

knative-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, mbaynton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/operator/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment