search

knative / pkg

Knative common packages
Apache License 2.0
259 stars 331 forks source link

psbinding webhook leaks inclusion/exclusion lables #1232

Open lberk opened 4 years ago

lberk commented 4 years ago

Expected Behavior

Once all podspecable bindings are removed from a namespace, the webhook should remove the label to ensure we don't pollute the namespace

Actual Behavior

The psbinding reconcile leaves a bindings.knative.dev/include: true label on namespaces it touches

Steps to Reproduce the Problem

  1. create a compliant knative source & sink
  2. `k get ns -oyaml | grep

Additional Info

lberk commented 4 years ago

One approach might be to ensure matching labels are removed if there are no remaining psObj's in the subject's namespace? /cc @mattmoor

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

mattmoor commented 4 years ago

/lifecycle frozen