Open nader-ziada opened 2 years ago
cc @runzexia who included the KProbe logic in the drainer - is there a reason you couldn't consume the handler from knative.dev/networking ?
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
/remove-lifecycle stale
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
/lifecycle frozen
/area networking
Follow up from Serving PR: https://github.com/knative/serving/pull/12033
I think that makes the network.NewProbeHandler a noop in this instance https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37