knative / pkg

Knative common packages
Apache License 2.0
259 stars 331 forks source link

Remove KProbe logic from Drainer #2324

Open nader-ziada opened 2 years ago

nader-ziada commented 2 years ago

/area networking

Follow up from Serving PR: https://github.com/knative/serving/pull/12033

I think that makes the network.NewProbeHandler a noop in this instance https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37


-  Other comment about same https://github.com/knative/serving/pull/12033#discussion_r735640426 
dprotaso commented 2 years ago

cc @runzexia who included the KProbe logic in the drainer - is there a reason you couldn't consume the handler from knative.dev/networking ?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

pierDipi commented 2 years ago

/remove-lifecycle stale

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

dprotaso commented 2 years ago

/lifecycle frozen