knative / pkg

Knative common packages
Apache License 2.0
257 stars 330 forks source link

Skip lease with empty holder #3042

Closed skonto closed 4 months ago

skonto commented 4 months ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 4 months ago

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/pkg/pull/3042): > > > > ># Changes > > > >- See https://github.com/knative/serving/issues/15238 and https://github.com/knative/serving/pull/15251#issuecomment-2133304924 >- Leases don't seem to be garbage collected when tested locally (not even after 1h as stated in docs). >Knative creates leases without owner refs. > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.73%. Comparing base (03bf3de) to head (da2e316). Report is 33 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3042 +/- ## ========================================== - Coverage 78.75% 78.73% -0.02% ========================================== Files 188 189 +1 Lines 11107 8873 -2234 ========================================== - Hits 8747 6986 -1761 + Misses 2094 1621 -473 Partials 266 266 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 4 months ago

/lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/knative/pkg/blob/main/test/OWNERS)~~ [dprotaso,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment