search

knative / pkg

Knative common packages
Apache License 2.0
257 stars 330 forks source link

Fix rand source in name #3070

Closed skonto closed 3 months ago

skonto commented 3 months ago

Changes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.45%. Comparing base (26bc7b4) to head (affc81c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3070 +/- ## ======================================= Coverage 78.44% 78.45% ======================================= Files 191 191 Lines 8941 8938 -3 ======================================= - Hits 7014 7012 -2 + Misses 1664 1663 -1 Partials 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 3 months ago

actually let's get this merged - the change can be done in a follow up

/lgtm /approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/knative/pkg/blob/main/test/OWNERS)~~ [dprotaso,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment