search

knative / pkg

Knative common packages
Apache License 2.0
259 stars 331 forks source link

Migrate from OpenCensus to OpenTelemetry #855

Open anniefu opened 5 years ago

anniefu commented 5 years ago

OpenCensus & OpenTracing have merged to form OpenTelemetry (see https://github.com/census-instrumentation/opencensus-go & https://medium.com/opentracing/a-roadmap-to-convergence-b074e5815289).

Knative should to move to instrumenting metrics and traces with OpenTelemetry instead of OpenCensus ahead of OpenCensus getting deprecated.

grantr commented 4 years ago

Looks like OpenTelemetry Go SDK is in beta now: https://github.com/open-telemetry/opentelemetry-go

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

vagababov commented 4 years ago

/lifecycle frozen /assign @evankanderson @jjzeng-seattle

skonto commented 3 years ago

I have done an evaluation on this topic here are the takeaways. From my POV otel is not ready yet, I would wait for GA. There is also a spike for this in wip status. We discussed this on a community meeting as well.

evankanderson commented 3 years ago

/unassign

evankanderson commented 3 years ago

/unassign @jjzeng-seattle

dprotaso commented 2 years ago

FYI - there's a bridge for OpenCensus => OpenTelemetry

So we can use the OTel exporters and slowly transition the API usage over

https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus#user-journey

I think tracing would be the best POC to test this out with

dprotaso commented 1 year ago

FYI - Bug in metrics/otelhttp handler causes high cardinality https://github.com/open-telemetry/opentelemetry-go-contrib/issues/3765 - fixed in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277

dprotaso commented 1 year ago

When performing the migration we should consider how we name the service -

The suggestion here is that hostname is not a good one because it changes as pods come up and down - https://github.com/knative/serving/pull/14075

skonto commented 1 year ago

Otel go sdk i snow stable wrt metrics. See https://github.com/knative/serving/issues/14486 for pointers. We should define a plan on how to work on this one.