search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Removing logging override examples from config-logging.yaml #184

Closed garron closed 5 years ago

garron commented 5 years ago

I believe this file was copied from knative-serving and these examples could give the impression that the knative-serving logging configuration can be changed from the operator's config-logging, which isn't the case.

Proposed Changes

Release Note

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garron, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment