search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

checks version of deployment matches version go file #201

Closed matzew closed 4 years ago

matzew commented 5 years ago

Task:

Change the controller to look for the serving.knative.dev/release label in the manifest and use that to set the status.version in the CR.

Add a test for that too

matzew commented 5 years ago

/assign @matzew

matzew commented 4 years ago

/assign @aliok

knative-prow-robot commented 4 years ago

@matzew: GitHub didn't allow me to assign the following users: aliok.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/knative/serving-operator/issues/201#issuecomment-554938210): >/assign @aliok Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 4 years ago

I will do the same thing in https://github.com/knative/eventing-operator/pull/42