search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

The Image transformation is still missing the support of private secret #221

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

@garron As we discussed on slack, we probably need to verify if this support is missing for image transformation. If so, we will add it the same way as we did for the deployment transformation.

houshengbo commented 4 years ago

/assign @garron

garron commented 4 years ago

For context, this is related to #124

garron commented 4 years ago

I've taken a look at adding this and it's pretty straightforward. However, it's worth pointing out that this will not result in the queue proxy in the various namespaces that ksvcs are deployed to using the imagePullSecrets.

As far as I can tell, there might not be a practical way to get the queue proxy using imagePullSecrets without changes to serving. Because the queue proxy runs in various namespaces, any imagePullSecrets would have to exist in those namespaces or be copied there.

garron commented 4 years ago

CC: @mattmoor

garron commented 4 years ago

I wrote up https://github.com/knative/serving/issues/6075 to track next steps around getting imagePullSecrets working with the queue proxy.