search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Add a "DependenciesInstalled" condition that defaults to true #236

Closed jcrossley3 closed 4 years ago

jcrossley3 commented 4 years ago

This allows any other controllers, e.g. platform-specific ones, watching the KnativeServing resource to defer its "Ready" condition until any deps on that platform, e.g. a service mesh, are successfully installed.

This is effectively a no-op unless some other controller marks the condition as "missing" or "installing".

knative-metrics-robot commented 4 years ago

The following is the coverage report on the affected files. Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/knativeserving_lifecycle.go 7.7% 57.9% 50.2
knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcrossley3, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [jcrossley3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment