Update the year of the copyright to 2020 in the template

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/

Apache License 2.0

39 stars 45 forks source link

Update the year of the copyright to 2020 in the template #254

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

Proposed Changes

As we move into the year of mouse, update the year to 2020 in the template.

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

markusthoemmes commented 4 years ago

We don't usually do this in other repos. Is this required?

houshengbo commented 4 years ago

/hold Let me do a confirmation about the change.

houshengbo commented 4 years ago

/hold cancel @markusthoemmes You are correct. The source code should stay with the original, so only change the year in the template.

Here is some discussions: https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated

In general, there are two types of voices:

Stay with the year when the work is first published.
We CAN update a copyright year only if contributions are made to the work during that year.

k4leung4 commented 4 years ago

/lgtm

it does seem we do this for the template in serving and eventing https://github.com/knative/serving/pull/6464 https://github.com/knative/eventing/pull/2359