search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Print error in knativeServingDelete #268

Closed nak3 closed 4 years ago

nak3 commented 4 years ago

This makes a tiny change that knativeServingDelete prints missing error message.

Currently the error prints as:

    --- FAIL: TestKnativeServingDeployment/delete (30.65s)
        knativeservingdeployment_test.go:244: The CustomResourceDefinition ingresses.networking.internal.knative.dev failed to be deleted

and it is difficult to find the reason why clients.Dynamic.Resource(gvrs).Get() failed to delete.

/lint

Release Note

NONE
trshafer commented 4 years ago

/approve

trshafer commented 4 years ago

/lgtm

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, trshafer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [trshafer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment