search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Fix OLM metadata for 0.11.0 #269

Closed aliok closed 4 years ago

aliok commented 4 years ago

Fixes # 271

Proposed Changes

Release Note

NONE
knative-prow-robot commented 4 years ago

Hi @aliok. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k4leung4 commented 4 years ago

/ok-to-test

k4leung4 commented 4 years ago

can you update the PR description to explain what was wrong and how you are fixing it? looking at the change alone does not make it obvious what is happening.

aliok commented 4 years ago

@k4leung4 Definitely!

Just created an issue https://github.com/knative/serving-operator/issues/271

houshengbo commented 4 years ago

/lgtm /approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment