search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

How to sync-up with the latest manifest of knative in a timely fashion #276

Open houshengbo opened 4 years ago

houshengbo commented 4 years ago

Problem This issue applies to eventing-operator as well. If knative has experienced some significant changes, which can lead to key resource deletion, but it has not released this version yet, how can operator catch the latest change and implement based this change in time?

For example, eventing dropped sources-controller https://github.com/knative/eventing/pull/2448, we know we need to add logic removing the sources-controller deployment in the reconcile loop, but how can we pull the latest manifest and test with operator code? I do not think we should wait until the next version is released for operator development and test.

Persona: Developers

Exit Criteria A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional): How many developer-days do you think this may take to resolve?

Additional context (optional) Add any other context about the feature request here.

aliok commented 4 years ago

but how can we pull the latest manifest and test with operator code

We need some CI magic to have nightly releases then?

houshengbo commented 4 years ago

https://github.com/knative/eventing-operator/pull/108 This PR can be used as reference. We can create a similar one, pulling the nightly release can pushing as a new PR for review. We can run it every day or week.

aliok commented 4 years ago

This PR can be used as reference. We can create a similar one, pulling the nightly release can pushing as a new PR for review. We can run it every day or week.

+1 on this one. I can work on this.

@mattmoor how is the setup for PRs like https://github.com/knative/eventing-operator/pull/108 ?