search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Add image override logic for DaemonSet #281

Closed savitaashture closed 4 years ago

savitaashture commented 4 years ago

Fixes https://github.com/knative/serving-operator/issues/280

Proposed Changes

Release Note

This PR will be validated when release manifest updated to changes from knative/serving#6624 This PR has dependency knative.dev/pkg

savitaashture commented 4 years ago

I almost feel like it's worth biting the bullet and using PodSpecable. Seems like that would reduce a lot of the code in the PR and simultaneously pull in support for StatefulSets as well. WDYT?

Yep true i will make use of PodSpecable in the PR and update

savitaashture commented 4 years ago

CI fail until PR merge

savitaashture commented 4 years ago

@jcrossley3 thank you Addressed all the comments

knative-metrics-robot commented 4 years ago

The following is the coverage report on the affected files. Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeserving/common/images.go 87.3% 85.1% -2.2
jcrossley3 commented 4 years ago

Thanks @savitaashture :smile: /lgtm /approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcrossley3, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [jcrossley3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment