knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Installing KnativeServing CR in namespace not named knative-serving doesn't configure the APIService correctly #283

Closed whitleykeith closed 4 years ago

whitleykeith commented 4 years ago

Describe the bug When installing the KnativeServing CR in namespace "foo", the operator also configures the APIService which always defaults to look for the knative-serving/autoscaler service. The autoscaler is not discoverable at that addresss

Expected behavior The APIService is configured to look for foo/autoscaler, assuming "foo" is the namespace the KnativeServing CR has been installed into.

To Reproduce Install a KnativeServing CR into a namespace not named "knative-serving"

Knative release version 0.11.0

aliok commented 4 years ago

IMO, this is more of a question if we would like to support installing Knative in any namespace. All the Knative documentation I can see instructs users to install things on specific namespaces.

We should do one of these:

Option A:

Option B:

cc @k4leung4 @houshengbo @jcrossley3

aliok commented 4 years ago

@markusthoemmes told me that Knative serving components should work fine in any namespace as they use system.Namespace(). So, let's fix this bug and make sure we have some tests for installing Knative into other namespaces.