search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Add a comment about why cluster-admin is necessary. #284

Closed Cynocracy closed 4 years ago

Cynocracy commented 4 years ago

Unfortunately it appears that in order to use an aggregated clusterrole we need the operator to be a cluster-admin. This should help prevent confusion re: why we have both an explicit list and a blanket */* granted to the operator service account.

See #282

Proposed Changes

Release Note

NONE

k4leung4 commented 4 years ago

/lgtm

Cynocracy commented 4 years ago

/assign @greghaynes

(Is it normal to have separate LGTMer and approver? :)

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynocracy, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Cynocracy commented 4 years ago

Thank you!