search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Support reading KubeConfig from KUBECONFIG env var #293

Closed aliok closed 4 years ago

aliok commented 4 years ago

Fixes #292

Proposed Changes

Release Note

NONE

Same PR for eventing operator: https://github.com/knative/eventing-operator/pull/100

knative-prow-robot commented 4 years ago

Hi @aliok. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 4 years ago

Squashed and ready for final review

aliok commented 4 years ago

for the nit. Feel free to unhold if you don't want to fix that.

I can't. I lack permissions :)

aliok commented 4 years ago

oh man this failed :(

flag redefined: master

Can't redefine a flag. We either need to make the flags in sharedmain exposed or do some hack around reading the same flag again in our controller.

@markusthoemmes wdyt?

markusthoemmes commented 4 years ago

Dang. For this PR I'd roll back the change to the "normal" Main function and use the sharedmain.GetConfig helper in main.go as well. That'll land your initial reason to open the PR in the first place.

We can then discuss what to do with the rest.

aliok commented 4 years ago

/retest

knative-prow-robot commented 4 years ago

@aliok: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/knative/serving-operator/pull/293#issuecomment-585639381): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 4 years ago

Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

oh boy. cc @markusthoemmes

markusthoemmes commented 4 years ago

/ok-to-test

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment