search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Remove all the arguments for controller #294

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

Proposed Changes

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
markusthoemmes commented 4 years ago

This is a duplicate of #293, I think? Also: Should we really drop the master/kubeconfig options for manifestival usage? I feel like that'll cause weird behavior if somebody is using that and it's not consistently used between the "normal" clients and manifestival's.

/hold

For waiting for #293 to merge first.