search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Update to Manifestival v0.1.0 #297

Closed jcrossley3 closed 4 years ago

jcrossley3 commented 4 years ago

This introduces support for different client implementations, e.g. client-go and controller-runtime. This repo uses client-go so that requires a dependency on the repo implementing the client-go manifestival client.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [jcrossley3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k4leung4 commented 4 years ago

/lgtm