Closed houshengbo closed 4 years ago
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
@googlebot I consent.
@googlebot I consent
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aliok, houshengbo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold I have new findings, still verifying.
/hold cancel
The following is the coverage report on the affected files.
Say /test pull-knative-serving-operator-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/reconciler/knativeserving/common/images.go | 85.1% | 87.3% | 2.2 |
/lgtm
Proposed Changes
Release Note