Closed houshengbo closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: houshengbo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@houshengbo any instructions to run this test locally? I couldn't on Minikube and on OpenShift
@aliok this is good question, but it seems to me that running the tests against GKE is the ONLY way to verify the tests.
but it seems to me that running the tests against GKE is the ONLY way to verify the tests.
then it lgtm as things pass on GKE. I created https://github.com/knative/serving-operator/issues/317 so that I don't forget it and hopefully make things working later.
/lgtm
Fixes #310
Proposed Changes
Release Note