Run the upgrade and downgrade tests in the upgrade prow job

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/

Apache License 2.0

39 stars 45 forks source link

Run the upgrade and downgrade tests in the upgrade prow job #300

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

Fixes #310

Proposed Changes

This PR adds the execution of upgrade and downgrade tests into the operator prow job.
This PR refactors the e2e-common script, to accommodate the changes in upgrade tests.
This PR adds the deployment verification for Knative in operator's upgrade tests.

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

aliok commented 4 years ago

@houshengbo any instructions to run this test locally? I couldn't on Minikube and on OpenShift

houshengbo commented 4 years ago

@aliok this is good question, but it seems to me that running the tests against GKE is the ONLY way to verify the tests.

aliok commented 4 years ago

but it seems to me that running the tests against GKE is the ONLY way to verify the tests.

then it lgtm as things pass on GKE. I created https://github.com/knative/serving-operator/issues/317 so that I don't forget it and hopefully make things working later.

/lgtm